Skip to main content
Latest news: [[ newestAnnouncement.title ]] Learn more
InVision Support Home Page
Sign in
InVision ambassador ambassador
Marcin Glombiowski
Marcin Glombiowski Updated

Yarn2 support

Hi,

In current state dsm-storybook is incapable of supporting yarn monorepo and yarn 2 pnp approach. As far as I can tell its caused by lots of "node_modules" tight coupling whit in the package. Are there any plans of migrating into "require.resovel()" approach instead of pointing out paths imperatively ? 

This issue blocks us from making the migration. Semi-solution would be option to provide our own "build-storybook" command.

Publish fails at this state:
DSM => Creating Storybook bundle...
The system cannot find the path specified.
DSM => × Failed to build Storybook. For more details, try to run "build-storybook". For further assistance visit (https://support.invisionapp.com).


In code it is looking for:
node_modules\.bin\cross-env
node_modules\.bin\build-storybook

while with PnP they will never exist, that's why require.resolve is recommended.

I dont see any option to override this build command. Running "yarn build-storybook" works perfectly fine.

This post is associated with a known feature request: [[ problemTicketSubject ]]. Let our Product team know that you’re interested in this feature.

Sign in to add your vote

Thanks for taking the time to share your feedback about making our product better. We’ve let our Product team know that you’re interested in this feature so they can factor that into their product strategy.

0

comments

Sort by

Marcin Glombiowski
InVision ambassador Marcin Glombiowski , ambassador Edited

After further investigation it also seems that dsm-storybook plugin is fixed on some specific storybook versions, the one that was testes here (6.4.0-alpha.14) rendered broken due to dsm plugin error.

0
Gerald hemmers
InVision ambassador Gerald hemmers , ambassador

We had some issues in the past with the DSM storybook. Our solution, hosting our own storybook and linking it to dsm. 

That gave use more flexibility, maybe not a workable solution for you but for us it is working like a charm. Hope it helps.

Gerald

0
Raynor B
InVision ambassador Raynor B , InVision Employee , ambassador

Hi Marcin, 

Thanks for taking the time to reach out to our Community and share your feedback. We really appreciate it!

Our DSM-Storybook integration does not currently support the Yarn 2 Plug'n'Play (PnP) feature, but this is a potential feature that our Product team is tracking the interest for.

I'll go ahead and open a ticket on your behalf to track your interest for this. Please keep an eye out for an email indicating that we’ve formally tracked your feedback.

Perhaps Gerald's suggestion might be helpful, but please feel free to get in touch if you have any additional questions. 

Thanks, Marcin!

Best,
Raynor

NOTE: If anybody else would like to add their feedback about this potential feature, please “ADD YOUR VOTE” using the button on the original post.

0

join the conversation

To comment, sign up or sign in.